Add dynamic-codecs package
#289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0591177 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @lorisleiva and the rest of your teammates on |
lorisleiva
force-pushed
the
loris/dynamic-codecs
branch
5 times, most recently
from
00bba59 to
71b0830
Compare
lorisleiva
force-pushed
the
loris/dynamic-codecs
branch
11 times, most recently
from
8a805f1 to
d0fdc21
Compare
lorisleiva
force-pushed
the
loris/dynamic-codecs
branch
from
d0fdc21 to
0591177
Compare
ngundotra
approved these changes
Nov 5, 2024
ngundotra
left a comment
ngundotra
left a comment
There was a problem hiding this comment.
LGTM! Looking forward to dynamic-parsers package!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
dynamic-codecspackage that allows us to createCodecinstances on demand (as defined in@solana/codecs) from Codama nodes.This package is a bit low-level since the intention is for it to be used inside another
dynamic-parserspackage which will be created shortly after this PR is merged. The goal of thedynamic-codecspackage is to focus on the foundations of creating codecs for any nodes.Namely, it offers a
getNodeCodecfunction that, given the fullNodePathof a node, returns aCodec<unknown>that enables encoding and decoding data for that node. Here's an example:See the README of the new package for more information.